fix createCluster - copy options.defaults.socket before modifying it
#2783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soccermax
changed the title
leibale
approved these changes
Jul 2, 2024
nice, thanks for the fast reaction |
leibale
changed the title
options.defaults.socket before modifying it
3 tasks
florian-schunk
pushed a commit
to florian-schunk/node-redis
that referenced
this pull request
Jun 18, 2025
redis#2783) * shallow copy of this.#options.defaults.socket * shallow copy of this.#options.defaults.socket * nit --------- Co-authored-by: Max Gruenfelder <[email protected]> Co-authored-by: Leibale Eidelman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2373 introduced a bug into the creation of cluster clients. The issue is that provided options for creating a socket are changed. The function
clientOptionsDefaultsincluster-slots.tsis called twice once withdisableReconnectfalseand the second call is the real call for creating clients but the functionclientOptionsDefaultsis overridingthis.#options.defaults.socketat line 289 becauseresult.socketis the same reference asthis.#options.defaults.socketfix #2721
Checklist
npm testpass with this change (including linting)?